Emoji in nicks causes miscalculation of bytes in long message splitter #4

Closed
opened 2022-11-08 00:03:46 -05:00 by foxiepaws · 3 comments

A miscalculation occurs when a display name has emoji in it.

foxie 🦊 🐺 🦦 🐉 🐈⬛ 🐆 🦨 🦝 — Today at 11:53 PM
Pellentesqueluctustinciduntarcu,idportanequevolutpatut.Etiammagnafelis,pulvinaraerosin,molestieposuerearcu.Quisqueconsecteturnuncnonposueretincidunt.Curabiturnonvelitquistellustempussempernecalorem.Utbibendumorciaquammalesuada,nectinciduntduifacilisis.Nullamsollicitudinsitametligulainsodales.Vivamusfinibustempusmetusetbibendum.Aeneanvitaeultricesmauris.Donecimperdietdolornontellusimperdietsemper.Nuncquisfinibuslorem.Quisquevelodioblandit,variusfelisvitae,fermentumerat.Nuncfaucibusviverrametusvellacinia.Inatmagnalacus.Donecnongravidamassa.Craseuipsumodio.Inhachabitasseplateadictumst.Phaselluscondimentumefficitureros,eupretiumipsumeleifendquis.Vivamusegestas,maurisegetgravidafinibus,purusdiambibendumipsum,quispretiumnibhlacusacjusto.Duistortorquam,accumsanaccondimentumvitae,gravidautvolutpat.

becomes

23:53 <vulpineden> <foxie 🦊 🐺 🦦 🐉 🐈⬛ 🐆 🦨 🦝> Pellentesqueluctustinciduntarcu,idportanequevolutpatut.Etiammagnafelis,pulvinaraerosin,molestieposuerearcu.Quisqueconsecteturnuncnonposueretincidunt.Curabiturnonvelitquistellustempussempernecalorem.Utbibendumorciaquammalesuada,nectinciduntduifacilisis.Nullamsollicitudinsitametligulainsodales.Vivamusfinibustempusmetusetbibendum.Aeneanvitaeultricesmauris.Donecimperdietdolornontellusimpe
23:53 <vulpineden> <foxie 🦊 🐺 🦦 🐉 🐈⬛ 🐆 🦨 🦝> .Nuncfaucibusviverrametusvellacinia.Inatmagnalacus.Donecnongravidamassa.Craseuipsumodio.Inhachabitasseplateadictumst.Phaselluscondimentumefficitureros,eupretiumipsumeleifendquis.Vivamusegestas,maurisegetgravidafinibus,purusdiambibendumipsum,quispretiumnibhlacusacjusto.Duistortorquam,accumsanaccondimentumvitae,gravidautvolutpat.

remains rdietsemper

and

Menagerie.(🧚♀*(🦊🍄🐉🐰🦄🌸💻)) — Today at 11:24 PM
00.0.00.00 - - [07/Nov/2022:20:34:04 -0700] "GET /packs/media/fonts/roboto/roboto-regular-webfont-e6505d5d85943244ec91d5e3002791f2.woff2 HTTP/2.0" 200 191468 "https://________.___/packs/css/flavours/glitch/common-1dba2fb7.chunk.css" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/000.00 (KHTML, like Gecko) Chrome/000.0.0.0 Safari/000.00 OPR/00.0.0000.000" - the roboto part was triggering it.  I need to wire up a better way to detect bots.
23:24 <%discordirc> <Menagerie.(🧚♀*(🦊🍄🐉🐰🦄🌸💻))> 00.0.00.00 - - [07/Nov/2022:20:34:04 -0700] "GET /packs/media/fonts/roboto/roboto-regular-webfont-e6505d5d85943244ec91d5e3002791f2.woff2 HTTP/2.0" 200 191468 "https://________.___/packs/css/flavours/glitch/common-1dba2fb7.chunk.css" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/000.00 (KHTML, like Gecko) Chrome/000.0.0.0 Safari/000.00 OPR/00.0.0000.000" - the roboto p

remains art was triggering it. I need to wire up a better way to detect bots.

note: domains, IP and versions scrubbed to match length to protect privacy.

A miscalculation occurs when a display name has emoji in it. ``` foxie 🦊 🐺 🦦 🐉 🐈⬛ 🐆 🦨 🦝 — Today at 11:53 PM Pellentesqueluctustinciduntarcu,idportanequevolutpatut.Etiammagnafelis,pulvinaraerosin,molestieposuerearcu.Quisqueconsecteturnuncnonposueretincidunt.Curabiturnonvelitquistellustempussempernecalorem.Utbibendumorciaquammalesuada,nectinciduntduifacilisis.Nullamsollicitudinsitametligulainsodales.Vivamusfinibustempusmetusetbibendum.Aeneanvitaeultricesmauris.Donecimperdietdolornontellusimperdietsemper.Nuncquisfinibuslorem.Quisquevelodioblandit,variusfelisvitae,fermentumerat.Nuncfaucibusviverrametusvellacinia.Inatmagnalacus.Donecnongravidamassa.Craseuipsumodio.Inhachabitasseplateadictumst.Phaselluscondimentumefficitureros,eupretiumipsumeleifendquis.Vivamusegestas,maurisegetgravidafinibus,purusdiambibendumipsum,quispretiumnibhlacusacjusto.Duistortorquam,accumsanaccondimentumvitae,gravidautvolutpat. ``` becomes ``` 23:53 <vulpineden> <foxie 🦊 🐺 🦦 🐉 🐈⬛ 🐆 🦨 🦝> Pellentesqueluctustinciduntarcu,idportanequevolutpatut.Etiammagnafelis,pulvinaraerosin,molestieposuerearcu.Quisqueconsecteturnuncnonposueretincidunt.Curabiturnonvelitquistellustempussempernecalorem.Utbibendumorciaquammalesuada,nectinciduntduifacilisis.Nullamsollicitudinsitametligulainsodales.Vivamusfinibustempusmetusetbibendum.Aeneanvitaeultricesmauris.Donecimperdietdolornontellusimpe 23:53 <vulpineden> <foxie 🦊 🐺 🦦 🐉 🐈⬛ 🐆 🦨 🦝> .Nuncfaucibusviverrametusvellacinia.Inatmagnalacus.Donecnongravidamassa.Craseuipsumodio.Inhachabitasseplateadictumst.Phaselluscondimentumefficitureros,eupretiumipsumeleifendquis.Vivamusegestas,maurisegetgravidafinibus,purusdiambibendumipsum,quispretiumnibhlacusacjusto.Duistortorquam,accumsanaccondimentumvitae,gravidautvolutpat. ``` remains `rdietsemper` and ``` Menagerie.(🧚♀*(🦊🍄🐉🐰🦄🌸💻)) — Today at 11:24 PM 00.0.00.00 - - [07/Nov/2022:20:34:04 -0700] "GET /packs/media/fonts/roboto/roboto-regular-webfont-e6505d5d85943244ec91d5e3002791f2.woff2 HTTP/2.0" 200 191468 "https://________.___/packs/css/flavours/glitch/common-1dba2fb7.chunk.css" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/000.00 (KHTML, like Gecko) Chrome/000.0.0.0 Safari/000.00 OPR/00.0.0000.000" - the roboto part was triggering it. I need to wire up a better way to detect bots. ``` ``` 23:24 <%discordirc> <Menagerie.(🧚♀*(🦊🍄🐉🐰🦄🌸💻))> 00.0.00.00 - - [07/Nov/2022:20:34:04 -0700] "GET /packs/media/fonts/roboto/roboto-regular-webfont-e6505d5d85943244ec91d5e3002791f2.woff2 HTTP/2.0" 200 191468 "https://________.___/packs/css/flavours/glitch/common-1dba2fb7.chunk.css" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/000.00 (KHTML, like Gecko) Chrome/000.0.0.0 Safari/000.00 OPR/00.0.0000.000" - the roboto p ``` remains `art was triggering it. I need to wire up a better way to detect bots.` note: domains, IP and versions scrubbed to match length to protect privacy.
Poster
Owner

Likely caused by String.length/1 use instead of byte_size/1. Thankfully this will have a simple easy fix.

Likely caused by `String.length/1` use instead of `byte_size/1`. Thankfully this will have a simple easy fix.
foxiepaws self-assigned this 2022-11-08 00:13:34 -05:00
foxiepaws added spent time 2022-11-08 00:13:41 -05:00
5min
foxiepaws referenced this issue from a commit 2022-11-08 00:14:06 -05:00
Poster
Owner

it did not, in fact fix #4

it did not, in fact fix #4
foxiepaws added the
bug
label 2022-11-08 00:59:39 -05:00
Poster
Owner

dff5ec0bde/lib/irc_bot.ex (L89)

probably involves this

https://git.foxiepa.ws/foxiepaws/discordirc/src/commit/dff5ec0bde6d560641b701fdcf26006e4c6c679e/lib/irc_bot.ex#L89 probably involves this
foxiepaws added spent time 2022-11-08 01:03:02 -05:00
2min
foxiepaws added spent time 2022-11-08 01:03:10 -05:00
4min
foxiepaws deleted spent time 2022-11-08 01:03:22 -05:00
- 4min
foxiepaws deleted spent time 2022-11-08 01:03:30 -05:00
- 2min
foxiepaws added spent time 2022-11-08 01:03:38 -05:00
5min
foxiepaws started working 2022-11-08 16:44:36 -05:00
foxiepaws stopped working 2022-11-08 19:59:46 -05:00
3h 15min 10s
foxiepaws added spent time 2022-11-08 20:14:23 -05:00
2min
foxiepaws started working 2022-11-08 20:14:26 -05:00
foxiepaws referenced this issue from a commit 2022-11-08 20:34:37 -05:00
foxiepaws stopped working 2022-11-08 20:34:37 -05:00
20min 11s
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Total Time Spent: 3 hours 47 minutes
foxiepaws
3 hours 47 minutes
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: foxiepaws/HomingPigeon#4
There is no content yet.