Emoji in nicks causes miscalculation of bytes in long message splitter #4

A miscalculation occurs when a display name has emoji in it.

foxie 🦊 🐺 🦦 🐉 🐈⬛ 🐆 🦨 🦝 — Today at 11:53 PM
Pellentesqueluctustinciduntarcu,idportanequevolutpatut.Etiammagnafelis,pulvinaraerosin,molestieposuerearcu.Quisqueconsecteturnuncnonposueretincidunt.Curabiturnonvelitquistellustempussempernecalorem.Utbibendumorciaquammalesuada,nectinciduntduifacilisis.Nullamsollicitudinsitametligulainsodales.Vivamusfinibustempusmetusetbibendum.Aeneanvitaeultricesmauris.Donecimperdietdolornontellusimperdietsemper.Nuncquisfinibuslorem.Quisquevelodioblandit,variusfelisvitae,fermentumerat.Nuncfaucibusviverrametusvellacinia.Inatmagnalacus.Donecnongravidamassa.Craseuipsumodio.Inhachabitasseplateadictumst.Phaselluscondimentumefficitureros,eupretiumipsumeleifendquis.Vivamusegestas,maurisegetgravidafinibus,purusdiambibendumipsum,quispretiumnibhlacusacjusto.Duistortorquam,accumsanaccondimentumvitae,gravidautvolutpat.

becomes

23:53 <vulpineden> <foxie 🦊 🐺 🦦 🐉 🐈⬛ 🐆 🦨 🦝> Pellentesqueluctustinciduntarcu,idportanequevolutpatut.Etiammagnafelis,pulvinaraerosin,molestieposuerearcu.Quisqueconsecteturnuncnonposueretincidunt.Curabiturnonvelitquistellustempussempernecalorem.Utbibendumorciaquammalesuada,nectinciduntduifacilisis.Nullamsollicitudinsitametligulainsodales.Vivamusfinibustempusmetusetbibendum.Aeneanvitaeultricesmauris.Donecimperdietdolornontellusimpe
23:53 <vulpineden> <foxie 🦊 🐺 🦦 🐉 🐈⬛ 🐆 🦨 🦝> .Nuncfaucibusviverrametusvellacinia.Inatmagnalacus.Donecnongravidamassa.Craseuipsumodio.Inhachabitasseplateadictumst.Phaselluscondimentumefficitureros,eupretiumipsumeleifendquis.Vivamusegestas,maurisegetgravidafinibus,purusdiambibendumipsum,quispretiumnibhlacusacjusto.Duistortorquam,accumsanaccondimentumvitae,gravidautvolutpat.

remains rdietsemper

and

Menagerie.(🧚♀*(🦊🍄🐉🐰🦄🌸💻)) — Today at 11:24 PM
00.0.00.00 - - [07/Nov/2022:20:34:04 -0700] "GET /packs/media/fonts/roboto/roboto-regular-webfont-e6505d5d85943244ec91d5e3002791f2.woff2 HTTP/2.0" 200 191468 "https://________.___/packs/css/flavours/glitch/common-1dba2fb7.chunk.css" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/000.00 (KHTML, like Gecko) Chrome/000.0.0.0 Safari/000.00 OPR/00.0.0000.000" - the roboto part was triggering it.  I need to wire up a better way to detect bots.

23:24 <%discordirc> <Menagerie.(🧚♀*(🦊🍄🐉🐰🦄🌸💻))> 00.0.00.00 - - [07/Nov/2022:20:34:04 -0700] "GET /packs/media/fonts/roboto/roboto-regular-webfont-e6505d5d85943244ec91d5e3002791f2.woff2 HTTP/2.0" 200 191468 "https://________.___/packs/css/flavours/glitch/common-1dba2fb7.chunk.css" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/000.00 (KHTML, like Gecko) Chrome/000.0.0.0 Safari/000.00 OPR/00.0.0000.000" - the roboto p

remains art was triggering it. I need to wire up a better way to detect bots.

note: domains, IP and versions scrubbed to match length to protect privacy.

A miscalculation occurs when a display name has emoji in it. ``` foxie 🦊 🐺 🦦 🐉 🐈⬛ 🐆 🦨 🦝 — Today at 11:53 PM Pellentesqueluctustinciduntarcu,idportanequevolutpatut.Etiammagnafelis,pulvinaraerosin,molestieposuerearcu.Quisqueconsecteturnuncnonposueretincidunt.Curabiturnonvelitquistellustempussempernecalorem.Utbibendumorciaquammalesuada,nectinciduntduifacilisis.Nullamsollicitudinsitametligulainsodales.Vivamusfinibustempusmetusetbibendum.Aeneanvitaeultricesmauris.Donecimperdietdolornontellusimperdietsemper.Nuncquisfinibuslorem.Quisquevelodioblandit,variusfelisvitae,fermentumerat.Nuncfaucibusviverrametusvellacinia.Inatmagnalacus.Donecnongravidamassa.Craseuipsumodio.Inhachabitasseplateadictumst.Phaselluscondimentumefficitureros,eupretiumipsumeleifendquis.Vivamusegestas,maurisegetgravidafinibus,purusdiambibendumipsum,quispretiumnibhlacusacjusto.Duistortorquam,accumsanaccondimentumvitae,gravidautvolutpat. ``` becomes ``` 23:53 <vulpineden> <foxie 🦊 🐺 🦦 🐉 🐈⬛ 🐆 🦨 🦝> Pellentesqueluctustinciduntarcu,idportanequevolutpatut.Etiammagnafelis,pulvinaraerosin,molestieposuerearcu.Quisqueconsecteturnuncnonposueretincidunt.Curabiturnonvelitquistellustempussempernecalorem.Utbibendumorciaquammalesuada,nectinciduntduifacilisis.Nullamsollicitudinsitametligulainsodales.Vivamusfinibustempusmetusetbibendum.Aeneanvitaeultricesmauris.Donecimperdietdolornontellusimpe 23:53 <vulpineden> <foxie 🦊 🐺 🦦 🐉 🐈⬛ 🐆 🦨 🦝> .Nuncfaucibusviverrametusvellacinia.Inatmagnalacus.Donecnongravidamassa.Craseuipsumodio.Inhachabitasseplateadictumst.Phaselluscondimentumefficitureros,eupretiumipsumeleifendquis.Vivamusegestas,maurisegetgravidafinibus,purusdiambibendumipsum,quispretiumnibhlacusacjusto.Duistortorquam,accumsanaccondimentumvitae,gravidautvolutpat. ``` remains `rdietsemper` and ``` Menagerie.(🧚♀*(🦊🍄🐉🐰🦄🌸💻)) — Today at 11:24 PM 00.0.00.00 - - [07/Nov/2022:20:34:04 -0700] "GET /packs/media/fonts/roboto/roboto-regular-webfont-e6505d5d85943244ec91d5e3002791f2.woff2 HTTP/2.0" 200 191468 "https://________.___/packs/css/flavours/glitch/common-1dba2fb7.chunk.css" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/000.00 (KHTML, like Gecko) Chrome/000.0.0.0 Safari/000.00 OPR/00.0.0000.000" - the roboto part was triggering it. I need to wire up a better way to detect bots. ``` ``` 23:24 <%discordirc> <Menagerie.(🧚♀*(🦊🍄🐉🐰🦄🌸💻))> 00.0.00.00 - - [07/Nov/2022:20:34:04 -0700] "GET /packs/media/fonts/roboto/roboto-regular-webfont-e6505d5d85943244ec91d5e3002791f2.woff2 HTTP/2.0" 200 191468 "https://________.___/packs/css/flavours/glitch/common-1dba2fb7.chunk.css" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/000.00 (KHTML, like Gecko) Chrome/000.0.0.0 Safari/000.00 OPR/00.0.0000.000" - the roboto p ``` remains `art was triggering it. I need to wire up a better way to detect bots.` note: domains, IP and versions scrubbed to match length to protect privacy.

Likely caused by String.length/1 use instead of byte_size/1. Thankfully this will have a simple easy fix.

it did not, in fact fix #4

dff5ec0bde/lib/irc_bot.ex (L89)

probably involves this