From 9b131e5322361f949f8a633b77d722e848cc7a89 Mon Sep 17 00:00:00 2001 From: Zithia Satazaki Date: Mon, 28 Mar 2022 16:40:13 -0400 Subject: [PATCH] nuke non-pod global static warnings (we're an executable) --- xybrid/config/pluginregistry.cpp | 2 +- xybrid/data/graph.cpp | 2 +- xybrid/data/sample.cpp | 4 ++-- xybrid/nodes/effect/autopan.cpp | 1 + xybrid/nodes/effect/delay.cpp | 1 + xybrid/nodes/effect/ringmod.cpp | 1 + xybrid/nodes/effect/svf.cpp | 1 + xybrid/nodes/gadget/gainbalance.cpp | 1 + xybrid/nodes/gadget/ioport.cpp | 1 + xybrid/nodes/gadget/mixboard.cpp | 1 + xybrid/nodes/gadget/quicklevel.cpp | 1 + xybrid/nodes/gadget/transpose.cpp | 1 + xybrid/nodes/instrument/2x03.cpp | 1 + xybrid/nodes/instrument/testsynth.cpp | 1 + xybrid/nodes/instrument/thicc.cpp | 1 + xybrid/nodes/instrument/xriek.cpp | 1 + xybrid/nodes/sampler/beatpad.cpp | 1 + xybrid/nodes/sampler/capaxitor.cpp | 1 + xybrid/settingsdialog.cpp | 2 +- xybrid/ui/gadgets/buttongadget.cpp | 2 +- xybrid/ui/gadgets/labelgadget.cpp | 2 +- 21 files changed, 22 insertions(+), 7 deletions(-) diff --git a/xybrid/config/pluginregistry.cpp b/xybrid/config/pluginregistry.cpp index 974cf6b..a77211e 100644 --- a/xybrid/config/pluginregistry.cpp +++ b/xybrid/config/pluginregistry.cpp @@ -16,7 +16,7 @@ using Xybrid::Gadgets::IOPort; #include "util/strings.h" -namespace { +namespace { // clazy:excludeall=non-pod-global-static typedef std::list> fqueue; // typedef so QtCreator's auto indent doesn't completely break :| fqueue& regQueue() { static fqueue q; diff --git a/xybrid/data/graph.cpp b/xybrid/data/graph.cpp index bcddb18..b555f86 100644 --- a/xybrid/data/graph.cpp +++ b/xybrid/data/graph.cpp @@ -17,7 +17,7 @@ using namespace Xybrid::Config; #define qs QStringLiteral -namespace { +namespace { // clazy:excludeall=non-pod-global-static std::shared_ptr inf; bool c = PluginRegistry::enqueueRegistration([] { auto i = std::make_shared(); diff --git a/xybrid/data/sample.cpp b/xybrid/data/sample.cpp index d545201..e4f8419 100644 --- a/xybrid/data/sample.cpp +++ b/xybrid/data/sample.cpp @@ -235,7 +235,7 @@ std::shared_ptr Sample::fromFile(QString fileName) { qCritical() << (probe.errorString()); } auto mystdout = probe.readAllStandardOutput(); - auto mystderr = probe.readAllStandardError(); + // auto mystderr = probe.readAllStandardError(); auto doc = QJsonDocument::fromJson(mystdout); info = doc.object()["streams"].toArray().first().toObject(); } @@ -283,7 +283,7 @@ std::shared_ptr Sample::fromFile(QString fileName) { #endif -namespace { +namespace { // clazy:excludeall=non-pod-global-static bool exporting = false; std::unordered_map exportMap; } diff --git a/xybrid/nodes/effect/autopan.cpp b/xybrid/nodes/effect/autopan.cpp index 7a3232d..220c8a8 100644 --- a/xybrid/nodes/effect/autopan.cpp +++ b/xybrid/nodes/effect/autopan.cpp @@ -27,6 +27,7 @@ using namespace Xybrid::UI; #include +// clazy:excludeall=non-pod-global-static RegisterPlugin(AutoPan, { i->id = "fx:autopan"; i->displayName = "Auto Pan"; diff --git a/xybrid/nodes/effect/delay.cpp b/xybrid/nodes/effect/delay.cpp index 471c44e..4876f1e 100644 --- a/xybrid/nodes/effect/delay.cpp +++ b/xybrid/nodes/effect/delay.cpp @@ -26,6 +26,7 @@ using namespace Xybrid::UI; #include +// clazy:excludeall=non-pod-global-static RegisterPlugin(Delay, { i->id = "fx:delay"; i->oldIds = {"gadget:delay"}; diff --git a/xybrid/nodes/effect/ringmod.cpp b/xybrid/nodes/effect/ringmod.cpp index ff6f24f..5b94101 100644 --- a/xybrid/nodes/effect/ringmod.cpp +++ b/xybrid/nodes/effect/ringmod.cpp @@ -27,6 +27,7 @@ using namespace Xybrid::UI; #include +// clazy:excludeall=non-pod-global-static RegisterPlugin(RingMod, { i->id = "fx:ringmod"; i->displayName = "Ring Mod"; diff --git a/xybrid/nodes/effect/svf.cpp b/xybrid/nodes/effect/svf.cpp index eae38fb..80c5633 100644 --- a/xybrid/nodes/effect/svf.cpp +++ b/xybrid/nodes/effect/svf.cpp @@ -40,6 +40,7 @@ using namespace Xybrid::UI; #include +// clazy:excludeall=non-pod-global-static RegisterPlugin(SVF, { i->id = "fx:svf"; i->oldIds = {"gadget:svf"}; diff --git a/xybrid/nodes/gadget/gainbalance.cpp b/xybrid/nodes/gadget/gainbalance.cpp index a3c8772..8104b42 100644 --- a/xybrid/nodes/gadget/gainbalance.cpp +++ b/xybrid/nodes/gadget/gainbalance.cpp @@ -25,6 +25,7 @@ using namespace Xybrid::UI; #include +// clazy:excludeall=non-pod-global-static RegisterPlugin(GainBalance, { i->id = "gadget:gainbalance"; i->displayName = "Gain/Balance"; diff --git a/xybrid/nodes/gadget/ioport.cpp b/xybrid/nodes/gadget/ioport.cpp index 5692c12..17a1146 100644 --- a/xybrid/nodes/gadget/ioport.cpp +++ b/xybrid/nodes/gadget/ioport.cpp @@ -26,6 +26,7 @@ using namespace Xybrid::Audio; #include "util/strings.h" +// clazy:excludeall=non-pod-global-static RegisterPlugin(IOPort, { i->id = "ioport"; i->displayName = "I/O Port"; diff --git a/xybrid/nodes/gadget/mixboard.cpp b/xybrid/nodes/gadget/mixboard.cpp index dfad9b4..a950da5 100644 --- a/xybrid/nodes/gadget/mixboard.cpp +++ b/xybrid/nodes/gadget/mixboard.cpp @@ -29,6 +29,7 @@ using namespace Xybrid::UI; #include #include +// clazy:excludeall=non-pod-global-static RegisterPlugin(MixBoard, { i->id = "gadget:mixboard"; i->displayName = "Mixer Board"; diff --git a/xybrid/nodes/gadget/quicklevel.cpp b/xybrid/nodes/gadget/quicklevel.cpp index 8a5f608..f471918 100644 --- a/xybrid/nodes/gadget/quicklevel.cpp +++ b/xybrid/nodes/gadget/quicklevel.cpp @@ -23,6 +23,7 @@ using namespace Xybrid::UI; #include "data/audioframe.h" #include "data/porttypes.h" +// clazy:excludeall=non-pod-global-static RegisterPlugin(QuickLevel, { i->id = "gadget:quicklevel"; i->displayName = "Quick Level"; diff --git a/xybrid/nodes/gadget/transpose.cpp b/xybrid/nodes/gadget/transpose.cpp index c77b499..18205d2 100644 --- a/xybrid/nodes/gadget/transpose.cpp +++ b/xybrid/nodes/gadget/transpose.cpp @@ -21,6 +21,7 @@ using namespace Xybrid::UI; #include +// clazy:excludeall=non-pod-global-static RegisterPlugin(Transpose, { i->id = "gadget:transpose"; i->displayName = "Transpose"; diff --git a/xybrid/nodes/instrument/2x03.cpp b/xybrid/nodes/instrument/2x03.cpp index b7b5641..2ed4067 100644 --- a/xybrid/nodes/instrument/2x03.cpp +++ b/xybrid/nodes/instrument/2x03.cpp @@ -26,6 +26,7 @@ using namespace Xybrid::UI; #include #include +// clazy:excludeall=non-pod-global-static RegisterPlugin(I2x03, { i->id = "plug:2x03"; i->displayName = "2x03"; diff --git a/xybrid/nodes/instrument/testsynth.cpp b/xybrid/nodes/instrument/testsynth.cpp index 7252392..7a47271 100644 --- a/xybrid/nodes/instrument/testsynth.cpp +++ b/xybrid/nodes/instrument/testsynth.cpp @@ -23,6 +23,7 @@ using namespace Xybrid::UI; #include "nodelib/resampler.h" +// clazy:excludeall=non-pod-global-static RegisterPlugin(TestSynth, { i->id = "plug:testsynth"; i->displayName = "The Testron"; diff --git a/xybrid/nodes/instrument/thicc.cpp b/xybrid/nodes/instrument/thicc.cpp index 90f0e3f..07f062d 100644 --- a/xybrid/nodes/instrument/thicc.cpp +++ b/xybrid/nodes/instrument/thicc.cpp @@ -28,6 +28,7 @@ using namespace Xybrid::UI; #include #include +// clazy:excludeall=non-pod-global-static RegisterPlugin(Thicc, { i->id = "plug:thicc"; i->displayName = "THiCC"; diff --git a/xybrid/nodes/instrument/xriek.cpp b/xybrid/nodes/instrument/xriek.cpp index 8965f60..2ee99a0 100644 --- a/xybrid/nodes/instrument/xriek.cpp +++ b/xybrid/nodes/instrument/xriek.cpp @@ -26,6 +26,7 @@ using namespace Xybrid::UI; #include #include +// clazy:excludeall=non-pod-global-static RegisterPlugin(Xriek, { i->id = "plug:xriek"; i->displayName = "Xriek"; diff --git a/xybrid/nodes/sampler/beatpad.cpp b/xybrid/nodes/sampler/beatpad.cpp index d74c653..23276c2 100644 --- a/xybrid/nodes/sampler/beatpad.cpp +++ b/xybrid/nodes/sampler/beatpad.cpp @@ -42,6 +42,7 @@ using namespace Xybrid::UI; #include #include +// clazy:excludeall=non-pod-global-static RegisterPlugin(BeatPad, { i->id = "plug:beatpad"; i->displayName = "BeatPad"; diff --git a/xybrid/nodes/sampler/capaxitor.cpp b/xybrid/nodes/sampler/capaxitor.cpp index 48a9ad0..66c7914 100644 --- a/xybrid/nodes/sampler/capaxitor.cpp +++ b/xybrid/nodes/sampler/capaxitor.cpp @@ -41,6 +41,7 @@ using namespace Xybrid::UI; #include #include +// clazy:excludeall=non-pod-global-static RegisterPlugin(Capaxitor, { i->id = "plug:capaxitor"; i->displayName = "CapaXitor"; diff --git a/xybrid/settingsdialog.cpp b/xybrid/settingsdialog.cpp index acb7814..fec8853 100644 --- a/xybrid/settingsdialog.cpp +++ b/xybrid/settingsdialog.cpp @@ -20,7 +20,7 @@ using namespace Xybrid::Audio; SettingsDialog* SettingsDialog::instance = nullptr; -namespace { +namespace { // clazy:excludeall=non-pod-global-static std::vector>* bnd; void bind(QCheckBox* o, bool& v) { diff --git a/xybrid/ui/gadgets/buttongadget.cpp b/xybrid/ui/gadgets/buttongadget.cpp index e80a392..5ceeb17 100644 --- a/xybrid/ui/gadgets/buttongadget.cpp +++ b/xybrid/ui/gadgets/buttongadget.cpp @@ -9,7 +9,7 @@ using Xybrid::UI::ButtonGadget; #include -namespace { +namespace { // clazy:excludeall=non-pod-global-static const QFont font("Arcon Rounded", 8); } diff --git a/xybrid/ui/gadgets/labelgadget.cpp b/xybrid/ui/gadgets/labelgadget.cpp index 32978d9..1f4eb5b 100644 --- a/xybrid/ui/gadgets/labelgadget.cpp +++ b/xybrid/ui/gadgets/labelgadget.cpp @@ -6,7 +6,7 @@ using Xybrid::UI::LabelGadget; #include -namespace { +namespace { // clazy:excludeall=non-pod-global-static const QFont font("Arcon Rounded", 8); }