foxiepaws
/
weechat
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

core: fix the hardcoded separator in string_split_command

v2.8-utf8proc
Wojciech Kwolek 2016-05-08 12:14:17 +02:00
parent 2d5ea374af
commit a44bcaf080
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/wee-string.c
View File

@ -2118,7 +2118,7 @@ string_split_command (const char *command, char separator)
while(*ptr != '\0')
{
type = 0;
if (*ptr == ';')
if (*ptr == separator)
{
if (ptr == command)
type = 1;

10
tests/unit/core/test-string.cpp
View File

@ -942,6 +942,16 @@ TEST(String, SplitCommand)
string_free_split_command (argv);
/* separator other than ';' */
argv = string_split_command ("abc,de,fghi", ',');
CHECK(argv);
STRCMP_EQUAL("abc", argv[0]);
STRCMP_EQUAL("de", argv[1]);
STRCMP_EQUAL("fghi", argv[2]);
POINTERS_EQUAL(NULL, argv[3]);
string_free_split_command (argv);
/* free split with NULL */
string_free_split_command (NULL);
}